chore: tweaks to enroll non-evm warp routes #4447
Conversation
daniel-savu
requested review from
jmrossy,
yorhodes and
aroralanuk
as code owners
|
| chainsToGasCheck ?? chains, | ||
| minGas, | ||
| ); | ||
| // TODO: this should skip checks on non-evm chains |
There was a problem hiding this comment.
Why should we skip on non-evm?
There was a problem hiding this comment.
because the scripts just throw errors for non-evm chains - so whoever runs this script for non-evm chains should be warned that there's fewer checks, but still have the option to go ahead
Signed-off-by: pbio <[email protected]>
jmrossy
changed the title
| logGray(`Skipping balance check for non-EVM chain: ${chain}`); | ||
| continue; | ||
| } | ||
| const address = multiProvider.getSigner(chain).getAddress(); |
There was a problem hiding this comment.
Hey @daniel-savu
I am trying to build the cli from source but due to line 22 being removed in this change, "address" becomes undefined and later in line 25 and 31 "address" is read. Resulting in a failed build, also there are a few unused variables which are logged during the build.
Can you please find time to check it once, thank you in advance.
| minGas, | ||
| skipConfirmation, | ||
| ); | ||
| assertSigner(signer); |
Description
Drive-by changes
Related issues
Backward compatibility
Testing