feat: Generate Cosmos address for Injective #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4618 +/- ##
=======================================
Coverage 73.85% 73.85%
=======================================
Files 100 100
Lines 1423 1423
Branches 181 181
=======================================
Hits 1051 1051
Misses 351 351
Partials 21 21
|
ameten
force-pushed
the
ameten/fix_address_generation
branch
2 times, most recently
from
0e38f36 to
11e13e5
Compare
ameten
force-pushed
the
ameten/fix_address_generation
branch
from
11e13e5 to
6ac1ace
Compare
Injective uses different logic on generating account addresses from public key. It is implemented in this PR so that sender address is correctly generated from signer info of transaction. Yes Added unit tests Manual testing with Injective blockchain --------- Co-authored-by: Danil Nemirovsky <[email protected]>
ameten
force-pushed
the
ameten/fix_address_generation
branch
from
441a17b to
58cc9b6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ltyu
pushed a commit
that referenced
this pull request
Oct 8, 2024
### Description Injective uses different logic compared to Neutron and Osmosis to generate account addresses from public key. It is implemented in this PR so that sender address is correctly generated from signer info of transaction. Depending on the type of public key communicated in the transaction, we shall generate either Bitcoin-like or Ethereum-like address for Injective. We can also specify the type of account id for the signer. Bitcoin-like will be chosen by default, so, we don't need to change the configuration of Relayer. ### Drive-by changes Made some errors to be warnings. We'll add metrics to measure how frequent the issues are and decide how to fix them: 1. transaction contains multiple contract execution messages 2. transaction contains fees in unsupported denominations Made Scraper to refrain from recording transaction which it cannot parse properly. ### Backward compatibility Yes ### Testing Added unit tests Manual testing with Injective blockchain --------- Co-authored-by: Danil Nemirovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Injective uses different logic compared to Neutron and Osmosis to generate account addresses from public key. It is implemented in this PR so that sender address is correctly generated from signer info of transaction.
Depending on the type of public key communicated in the transaction, we shall generate either Bitcoin-like or Ethereum-like address for Injective.
We can also specify the type of account id for the signer. Bitcoin-like will be chosen by default, so, we don't need to change the configuration of Relayer.
Drive-by changes
Made some errors to be warnings. We'll add metrics to measure how frequent the issues are and decide how to fix them:
Made Scraper to refrain from recording transaction which it cannot parse properly.
Backward compatibility
Yes
Testing
Added unit tests
Manual testing with Injective blockchain