fix: function write_checkpoint did not write checkpoint_{index}_with_id.json files to the folder #4915
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded upload_and_log function
…id.json files to the folder
|
IvanPsurtcev
changed the title
daniel-savu
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4915 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
|
Thank you! |
Merged
via the queue into
hyperlane-xyz:main
with commit Dec 11, 2024
4d342db
38 of 41 checks passed
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
…id.json files to the folder (hyperlane-xyz#4915) ### Description Added a mechanism for writing checkpoint files to the checkpoint folder in the write_chekpoint function. Without this change we wrote a lot of files to the root folder, which was not a correct behavior.
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
…id.json files to the folder (hyperlane-xyz#4915) ### Description Added a mechanism for writing checkpoint files to the checkpoint folder in the write_chekpoint function. Without this change we wrote a lot of files to the root folder, which was not a correct behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a mechanism for writing checkpoint files to the checkpoint folder in the write_chekpoint function. Without this change we wrote a lot of files to the root folder, which was not a correct behavior.