Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): reenable gas enforcement check in e2e (non-cosmwasm) #5105

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Jan 4, 2025

Description

  • Move to valid 'gaspaymentenforcement' for e2e, which was earlier shortcircuiting to none (the default value for enforcement policy). This meant we were not checking if the relayer was enforcing a non-zero gas payment for either sealevel or EVM gas payments.
  • The igpHook set as part of the default hook for Kathy was not configured properly, hence was giving a quote of 0. Now, Kathy does set the IGP config (oracle and overhead). (Note: Kathy is soon to be deprecated, so this is more of a quick patch for e2e coverage).
  • Added a check for deserilization of 'gaspaymentenforcement' and panic if invalid to prevent this bug in the future.

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Jan 4, 2025

⚠️ No Changeset found

Latest commit: 1df2bce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aroralanuk aroralanuk marked this pull request as draft January 4, 2025 17:48
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (99c91d8) to head (1df2bce).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5105   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@aroralanuk aroralanuk marked this pull request as ready for review January 8, 2025 09:28
@aroralanuk aroralanuk changed the title fix(e2e): reenable gas enforcement check in e2e (non-cosm-wasm) fix(e2e): reenable gas enforcement check in e2e (non-cosmwasm) Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant