fix: warp route artifact symbol #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: acf0af5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jmrossy
approved these changes
Jan 17, 2025
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
Jan 20, 2025
…es (#5212) ### Description <!-- What's included in this PR? --> Fixes #5164 Fixed an issue where symbols were not taken into account when creating artifacts through warp deploy. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> Update registry packages ### Related issues <!-- - Fixes #[issue number here] --> Related issue: [registry fix](hyperlane-xyz/hyperlane-registry#499) ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> Yes ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> CLI Manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR along with a PR to the monorepo aims to fix the artifacts for warp route deployments by taking into account the symbol field, mentioned in this issue
WarpRouteOptionsas optional parameter toaddWarpRoutegetWarpRouteArtifactPathsto receive asymbolas the folder pathBackward compatibility
Yes
Testing
CLI
Unit test