Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement HypERC20 #2

Open
wants to merge 25 commits into
base: trevor/initial
Choose a base branch
from
Open

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented May 2, 2023

Some things to note

  • This only implements HypERC20 - not the collateral version or native version yet
  • There are some modest TODOs / notes about workarounds with the new storage API
  • This allows for different "local" decimals and "remote" decimals, as a workaround to the u64 balance accounting
  • Gas is paid for in a separate call because only one token type can be transferred per call
  • This only really works for sending tokens to EOAs, and not contracts. See https://hyperlaneworkspace.slack.com/archives/C04DZ2E65U5/p1682556318518589 for conversations around this. Technically you can transfer to an output that is a predicate that will transfer to a contract ID, but this may not be the ideal solution
  • The Fuel token standard isn't solidified, but I went off of what is currently in Create a standard abi for fungible tokens. FuelLabs/rfcs#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants