refactor: Refactor negative test cases in refund.test to use Jest assertions #3464
Conversation
Signed-off-by: Deepak CH <[email protected]>
Deepakchowdavarapu
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
@petermetz @outSH please review this !! |
There was a problem hiding this comment.
Thanks for the updates. In the future don't open a separate PR but contact us on discord so we can assist you with any git problems you may have :)
I've added a single commnet and I'd like you to fix the title as mentioned in previous PR, and read the contributing guide:
- Fix the title, use the one peter proposed in related issue (https://github.com/hyperledger/cacti/issues/3457).
| await expect( | ||
| htlcCoordinatorBesuApiClient.withdrawCounterpartyV1(withdrawCounterparty) | ||
| ).rejects.toThrowErrorMatchingSnapshot(); | ||
|
|
||
| await expect( | ||
| htlcCoordinatorBesuApiClient.withdrawCounterpartyV1(withdrawCounterparty) | ||
| ).rejects.toThrow(expect.objectContaining({ | ||
| response: { | ||
| data: { | ||
| cause: { | ||
| receipt: { | ||
| revertReason: expect.stringMatching(/0e494e56414c49445f5345435245540/) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| })); | ||
|
|
There was a problem hiding this comment.
Fix the indentation to match the rest of the file
There was a problem hiding this comment.
@Deepakchowdavarapu Plus one to everything @outSH asked for. Please also sync up the PR description with the commit message body.
If there were no breaking changes please do not put the string BREAKING CHANGE in the commit message. The parser will detect that as a breaking change just based on the presence of the string.
| await expect( | ||
| htlcCoordinatorBesuApiClient.withdrawCounterpartyV1(withdrawCounterparty) | ||
| ).rejects.toThrowErrorMatchingSnapshot(); |
There was a problem hiding this comment.
@Deepakchowdavarapu What does this additional assertion accomplish? Is this covering some edge case scenario that the other assertion does not?
|
Closing this pull request due to inactivity, but please feel free to reopen as needed and then we can continue the review. |
Refactor Negative Test Cases in refund.test.ts to Use Jest Assertions
Replaced try-catch blocks with Jest’s .rejects matcher for error scenarios
in refund.test.ts. Updated test cases to use .toMatch and .toThrow for
error assertions, improving test readability and maintainability.
Test results remain consistent, and all assertions now leverage Jest’s
built-in methods.
BREAKING CHANGE: None
Signed-off-by: Deepakchowdavarapu [email protected]