Skip to content

Commit

Permalink
[refactor] #2573: document limitation of parsing derives in proc macros
Browse files Browse the repository at this point in the history
Signed-off-by: Nikita Strygin <[email protected]>
  • Loading branch information
DCNick3 committed Sep 5, 2023
1 parent 554c342 commit baed2fb
Show file tree
Hide file tree
Showing 2 changed files with 96 additions and 0 deletions.
32 changes: 32 additions & 0 deletions data_model/derive/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,22 @@ use syn::parse_macro_input;
/// }
/// */
/// ```
///
/// ## A note on `#[derive(...)]` limitations
///
/// This proc-macro crate parses the `#[derive(...)]` attributes.
/// Due to technical limitations of proc macros, it does not have access to the resolved path of the macro, only to what is written in the derive.
/// As such, it cannot support derives that are used through aliases, such as
///
/// ```ignore
/// use getset::Getters as GettersAlias;
/// #[derive(GettersAlias)]
/// pub struct Hello {
/// // ...
/// }
/// ```
///
/// It assumes that the derive is imported and referred to by its original name.
#[proc_macro_attribute]
#[proc_macro_error::proc_macro_error]
pub fn model(_attr: TokenStream, input: TokenStream) -> TokenStream {
Expand Down Expand Up @@ -345,6 +361,22 @@ pub fn id_eq_ord_hash(input: TokenStream) -> TokenStream {
/// }
/// } */
/// ```
///
/// ## A note on `#[derive(...)]` limitations
///
/// This proc-macro crate parses the `#[derive(...)]` attributes.
/// Due to technical limitations of proc macros, it does not have access to the resolved path of the macro, only to what is written in the derive.
/// As such, it cannot support derives that are used through aliases, such as
///
/// ```ignore
/// use getset::Getters as GettersAlias;
/// #[derive(GettersAlias)]
/// pub struct Hello {
/// // ...
/// }
/// ```
///
/// It assumes that the derive is imported and referred to by its original name.
#[proc_macro_derive(Filter)]
pub fn filter_derive(input: TokenStream) -> TokenStream {
let event = parse_macro_input!(input as filter::EventEnum);
Expand Down
64 changes: 64 additions & 0 deletions ffi/derive/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,22 @@ fn parse_attributes(ts: TokenStream) -> Vec<syn2::Attribute> {
/// item wrapped with this macro (e.g. fieldless enums). This is so that most of the time
/// users can safely wrap all of their structs with this macro and not be concerned with the
/// cognitive load of figuring out which structs are converted to opaque pointers.
///
/// ## A note on `#[derive(...)]` limitations
///
/// This proc-macro crate parses the `#[derive(...)]` attributes.
/// Due to technical limitations of proc macros, it does not have access to the resolved path of the macro, only to what is written in the derive.
/// As such, it cannot support derives that are used through aliases, such as
///
/// ```ignore
/// use getset::Getters as GettersAlias;
/// #[derive(GettersAlias)]
/// pub struct Hello {
/// // ...
/// }
/// ```
///
/// It assumes that the derive is imported and referred to by its original name.
#[manyhow]
#[proc_macro]
pub fn ffi(input: TokenStream) -> TokenStream {
Expand Down Expand Up @@ -172,6 +188,22 @@ pub fn ffi(input: TokenStream) -> TokenStream {
///
/// * wrapping type must allow for all possible values of the pointer including `null` (it's robust)
/// * the wrapping types's field of the pointer type must not carry ownership (it's non owning)
///
/// ## A note on `#[derive(...)]` limitations
///
/// This proc-macro crate parses the `#[derive(...)]` attributes.
/// Due to technical limitations of proc macros, it does not have access to the resolved path of the macro, only to what is written in the derive.
/// As such, it cannot support derives that are used through aliases, such as
///
/// ```ignore
/// use getset::Getters as GettersAlias;
/// #[derive(GettersAlias)]
/// pub struct Hello {
/// // ...
/// }
/// ```
///
/// It assumes that the derive is imported and referred to by its original name.
#[manyhow]
#[proc_macro_derive(FfiType, attributes(ffi_type))]
pub fn ffi_type_derive(input: TokenStream) -> TokenStream {
Expand Down Expand Up @@ -240,6 +272,22 @@ pub fn ffi_type_derive(input: TokenStream) -> TokenStream {
/// FfiReturn::Ok
/// } */
/// ```
///
/// ## A note on `#[derive(...)]` limitations
///
/// This proc-macro crate parses the `#[derive(...)]` attributes.
/// Due to technical limitations of proc macros, it does not have access to the resolved path of the macro, only to what is written in the derive.
/// As such, it cannot support derives that are used through aliases, such as
///
/// ```ignore
/// use getset::Getters as GettersAlias;
/// #[derive(GettersAlias)]
/// pub struct Hello {
/// // ...
/// }
/// ```
///
/// It assumes that the derive is imported and referred to by its original name.
#[manyhow]
#[proc_macro_attribute]
pub fn ffi_export(attr: TokenStream, item: TokenStream) -> TokenStream {
Expand Down Expand Up @@ -365,6 +413,22 @@ pub fn ffi_export(attr: TokenStream, item: TokenStream) -> TokenStream {
/// fn __return_first_elem_from_arr(arr: *const [u8; 8]) -> u8;
/// } */
/// ```
///
/// ## A note on `#[derive(...)]` limitations
///
/// This proc-macro crate parses the `#[derive(...)]` attributes.
/// Due to technical limitations of proc macros, it does not have access to the resolved path of the macro, only to what is written in the derive.
/// As such, it cannot support derives that are used through aliases, such as
///
/// ```ignore
/// use getset::Getters as GettersAlias;
/// #[derive(GettersAlias)]
/// pub struct Hello {
/// // ...
/// }
/// ```
///
/// It assumes that the derive is imported and referred to by its original name.
#[manyhow]
#[proc_macro_attribute]
pub fn ffi_import(attr: TokenStream, item: TokenStream) -> TokenStream {
Expand Down

0 comments on commit baed2fb

Please sign in to comment.