-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable doc tests #5201
Merged
Merged
ci: enable doc tests #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s8sato
requested review from
mversic,
SamHSmith,
0x009922 and
dima74
as code owners
October 29, 2024 14:10
s8sato
force-pushed
the
ci/enable_doctests
branch
from
October 30, 2024 18:49
dc45a67
to
f9d60b6
Compare
0x009922
previously approved these changes
Oct 31, 2024
0x009922
previously approved these changes
Nov 5, 2024
Converted to draft as @mversic has another solution to the failing doc test, and I'd wait for his PR and rebase it |
mversic
requested changes
Nov 6, 2024
Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
s8sato
force-pushed
the
ci/enable_doctests
branch
from
November 6, 2024 12:02
5bdd50d
to
2f2fbec
Compare
mversic
approved these changes
Nov 6, 2024
0x009922
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Doc tests are disabled by default cargo-llvm-cov
Solution
Enable it
Checklist
CONTRIBUTING.md
.