Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable doc tests #5201

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Oct 29, 2024

Context

Doc tests are disabled by default cargo-llvm-cov

Solution

Enable it

Checklist

  • I've read CONTRIBUTING.md.
  • All review comments have been resolved.
  • All CI checks pass.

@s8sato s8sato self-assigned this Oct 29, 2024
@s8sato s8sato marked this pull request as ready for review October 29, 2024 14:10
@s8sato s8sato marked this pull request as draft October 29, 2024 15:32
@s8sato s8sato marked this pull request as ready for review October 30, 2024 20:08
@s8sato s8sato enabled auto-merge (squash) October 30, 2024 20:08
0x009922
0x009922 previously approved these changes Oct 31, 2024
.github/workflows/iroha2-dev-pr.yml Outdated Show resolved Hide resolved
0x009922
0x009922 previously approved these changes Nov 5, 2024
@s8sato s8sato disabled auto-merge November 5, 2024 05:12
@s8sato s8sato marked this pull request as draft November 5, 2024 05:13
@s8sato
Copy link
Contributor Author

s8sato commented Nov 5, 2024

Converted to draft as @mversic has another solution to the failing doc test, and I'd wait for his PR and rebase it

crates/iroha_telemetry_derive/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Shunkichi Sato <[email protected]>
@s8sato s8sato marked this pull request as ready for review November 6, 2024 12:03
@s8sato s8sato requested a review from DCNick3 as a code owner November 6, 2024 12:03
@s8sato s8sato enabled auto-merge (squash) November 6, 2024 12:06
@s8sato s8sato merged commit aef3df6 into hyperledger-iroha:main Nov 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants