Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --release flag to wasm_builder #5209

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a7e2a5f
feat: add option to build wasm with optimizations
aoyako Oct 30, 2024
acddbdc
fix: rename optimize to release in build_wasm.sh
aoyako Oct 30, 2024
1fdecf7
Merge branch 'main' into wasm_builder_flags
aoyako Oct 30, 2024
5384b00
chore: cargo fmt
aoyako Oct 30, 2024
986a835
fix: use correct binary directory for debug
aoyako Oct 30, 2024
7a5b957
chore: cargo fmt
aoyako Oct 30, 2024
3e6eb1f
fix: use profile env from compose files
aoyako Oct 31, 2024
65e547f
Merge branch 'main' into wasm_builder_flags
aoyako Oct 31, 2024
5c6e4a8
fix: stack overflow caused by compact
aoyako Nov 7, 2024
ade7dc3
Merge branch 'main' into wasm_builder_flags
aoyako Nov 7, 2024
441d939
feat: add help message to build wasm readme
aoyako Nov 7, 2024
fc8f661
feat: add help message to build wasm readme
aoyako Nov 7, 2024
77b8d44
fix: update failing tests
aoyako Nov 11, 2024
66465f7
Merge branch 'main' into wasm_builder_flags
aoyako Nov 11, 2024
afcf368
fix: revert changes in ci
aoyako Nov 11, 2024
a252e68
fix: update ci files
aoyako Nov 12, 2024
c2a1b94
chore: fmt
aoyako Nov 12, 2024
93e9a8c
Merge branch 'main' into wasm_builder_flags
aoyako Nov 12, 2024
b7820e4
feat: use correct profile from cargo
aoyako Nov 12, 2024
45df4a6
chore: fmt
aoyako Nov 12, 2024
dc2034e
fix: rename profile test->release
aoyako Nov 12, 2024
dbea8cc
fix: make release a default profile
aoyako Nov 13, 2024
4000ece
Merge branch 'main' into wasm_builder_flags
aoyako Nov 13, 2024
9f5db48
chore: fmt
aoyako Nov 13, 2024
ab3054a
fix: readme for wasm builder
aoyako Nov 13, 2024
e3edc40
fix: use shell instead of bash
aoyako Nov 13, 2024
20545b9
fix: reorder optimization process in build
aoyako Nov 13, 2024
89d1535
feat: add release profile
aoyako Nov 13, 2024
bd5ea86
fix: chec profile in ci
aoyako Nov 13, 2024
0fb6a4f
fix: revert
aoyako Nov 13, 2024
fe1189f
feat: get logs from failing ci
aoyako Nov 14, 2024
3182ebd
feat: advanced logging
aoyako Nov 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/nextest.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[profile.default]
retries = 2
retries = { backoff = "fixed", count = 2, delay = "3s" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For release it is good.


[profile.ci]
fail-fast = false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/iroha2-dev-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Build
run: ./scripts/build_wasm.sh
run: ./scripts/build_wasm.sh --profile=release
mversic marked this conversation as resolved.
Show resolved Hide resolved
- name: Upload all built WASMs
uses: actions/upload-artifact@v4
with:
Expand Down
Loading
Loading