Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add
--release
flag to wasm_builder #5209base: main
Are you sure you want to change the base?
feat: Add
--release
flag to wasm_builder #5209Changes from 12 commits
a7e2a5f
acddbdc
1fdecf7
5384b00
986a835
7a5b957
3e6eb1f
65e547f
5c6e4a8
ade7dc3
441d939
fc8f661
77b8d44
66465f7
afcf368
a252e68
c2a1b94
93e9a8c
b7820e4
45df4a6
dc2034e
dbea8cc
4000ece
9f5db48
ab3054a
e3edc40
20545b9
89d1535
bd5ea86
0fb6a4f
fe1189f
3182ebd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some CI workflows should keep
--release
build, at leastiroha2-release.yml
and maybeiroha2-custom-image.yml
@BAStos525 ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release
foriroha2-release.yml
PROFILE
variableThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
iroha2-release.yml
we use the tag taken fromgithub.ref_name
- it's the tag name. Should any changes be introduced?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only
*.wasm
quality is discussed here, which would only affect e.g. this lineThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will use
release
due to the need for additional resources (memory, fuel) and adjusted timeouts. Nevertheless, the debug flag can be set when building WASM.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like CI to use
test
when testing things andrelease
(ordeploy
) when deploying. Yes, this will require you to adjust timeouts and limits in thetest_network
(don't modify parameters ingenesis.json
)