Adding Boottime Feature #439

Web-Dev-Manoj · 2023-09-04T05:35:03Z

What this PR does / why we need it:

Load only the blocks and transactions as per the configuration. Currently the configuration defines to archive or delete old data from the database. But at the bootstrap time, the Explorer tries to read every data from block 0. This can be configured to load only the data from certain point in time that is as expected by the Explorer's configuration.

This will help in speeding up the bootstrap time of Explorer, the tool and the UI will be ready in shorter period.

Which issue(s) this PR fixes:

Fixes #393

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NO

Additional documentation, usage docs, etc.:

SunnyAjin · 2023-09-04T11:27:33Z

app/platform/fabric/sync/SyncService.ts

+			}
+		}
+
+		const missingBlocks = await this.persistence


Can you check whether data is flowing through the missingBlocks section. since when we have new blocks added, latest blocks are also synced and added into db in the above section.

Yes, data is flowing through the missingBlocks section as expected. As new blocks are added, the latest blocks are being synced and added into the database in the above section without any issues. Everything seems to be working as expected.

SunnyAjin · 2023-09-04T11:29:25Z

app/platform/fabric/sync/SyncService.ts

+
+		// Syncing Details
+		logger.info(
+			`Syncing blocks from ${startingBlockHeight} to ${latestBlockHeight}`


Please see the condition when number of blocks in config.json is greater than the number of blocks in ledger.

This has been handled. if the blocks that are mentioned in the config.json file, is greater than the blocks available, it will sync the blocks that are available at that point of time.

SunnyAjin · 2023-09-04T11:31:16Z

app/platform/fabric/sync/SyncService.ts

+					blockHeight
+				);
+				if (block) {
+					await this.processBlockEvent(client, block, noDiscovery);


Before calling processBlockEvent, can you please check block is available in db. If not you can add.

addressed this by adding a conditional check in the code. Now, before calling processBlockEvent, we verify whether the block is available in the database. If the block is not present, we add it as needed. This check ensures that processBlockEvent is only executed when the required data is available in the database, helping to maintain the integrity as expected.

ArchanaArige · 2023-09-11T04:22:16Z

hi @Web-Dev-Manoj ,
With the above made changes w.r.t this PR,
1.can you also please check the entire application ,dashboard in the display, the total no. of blocks, transactions count is correct or not etc. Perform clean check whether this code changes are not affecting the other modules.
3.Please test the code with the mutiple channels and multiple chaincodes installed . (test with two versions of Chaincode).
Example:
channel1 - chaincode1 -v1
post some txns
channel1 - chaincode1 - v2(upgrade the chaincode)
post some txns
channel2- chaincode2
4.Modify the test-cases accordingly.
5.Read-me also undergoes the changes. Make a section for this in ReadMe and document the steps.
Thanks.

Udhayakumari · 2023-09-30T05:12:13Z

README.md

+                    "name": "Test Network",
+                    "profile": "./connection-profile/test-network.json",
+                    "enableAuthentication": false,
+                    "bootMode": "ALL",


Please add the "noOfBlocks" as "0" in ALL mode as well

Added, noOfBlocks parameter as "0" below "ALL" mode also.

Udhayakumari · 2023-09-30T05:15:19Z

app/persistence/fabric/CRUDService.ts

@@ -540,6 +564,22 @@ export class CRUDService {
 	}
 	// Orderer BE-303

+	/**
+	 *


Please add what this function returns here for better understanding.

Added what the function is returning as mentioned.

Udhayakumari · 2023-09-30T05:16:58Z

app/persistence/fabric/CRUDService.ts

+	 * @memberof CRUDService
+	 */
+	async isBlockAvailableInDB(channel_genesis_hash: string, blockHeight: any) {
+		const count: any = await this.sql.getRowsBySQlCase(


Please give specific datatype instead of 'any'.

Updated the type to 'number' replacing 'any'.

Udhayakumari · 2023-09-30T05:17:41Z

app/persistence/fabric/CRUDService.ts

+			`SELECT COUNT(*) FROM blocks WHERE channel_genesis_hash= $1 AND blocknum = $2`,
+			[channel_genesis_hash, blockHeight]
+		);
+		console.log(count.count);


Can you please remove the console log here.

ArchanaArige

As discussed, in the channels tab, the complete no. of txns needs to be displayed. Please fix that issue.
2.As suggested in the Readme, make a note saying that if the noOfBlocks in Custom mode is selected 0, there is still the latest block is available in postgres db.
3.In the Readme, please add the noOfBlocks in ALL mode.

Web-Dev-Manoj · 2023-10-16T19:07:41Z

hi @Web-Dev-Manoj , With the above made changes w.r.t this PR, 1.can you also please check the entire application ,dashboard in the display, the total no. of blocks, transactions count is correct or not etc. Perform clean check whether this code changes are not affecting the other modules. 3.Please test the code with the mutiple channels and multiple chaincodes installed . (test with two versions of Chaincode). Example: channel1 - chaincode1 -v1 post some txns channel1 - chaincode1 - v2(upgrade the chaincode) post some txns channel2- chaincode2 4.Modify the test-cases accordingly. 5.Read-me also undergoes the changes. Make a section for this in ReadMe and document the steps. Thanks.

ArchanaArige

Please add the test-case file to the same PR. Please also squash the commits.

Signed-off-by: Web-Dev-Manoj <[email protected]>

ArchanaArige

looks good.

Web-Dev-Manoj requested a review from a team as a code owner September 4, 2023 05:35

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch 2 times, most recently from 8871e56 to 4dde9e4 Compare September 4, 2023 10:40

SunnyAjin reviewed Sep 4, 2023

View reviewed changes

SunnyAjin assigned Web-Dev-Manoj Sep 4, 2023

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch from 14019ca to 37968d4 Compare September 28, 2023 04:59

Udhayakumari reviewed Sep 30, 2023

View reviewed changes

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch from dc2f5de to bf65828 Compare October 4, 2023 08:17

ArchanaArige reviewed Oct 12, 2023

View reviewed changes

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch from bf65828 to f2a7d03 Compare October 16, 2023 18:06

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch from f8b2222 to 5870831 Compare November 8, 2023 03:20

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch 2 times, most recently from d2439b3 to 0d1d899 Compare November 19, 2023 17:47

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch from 0d1d899 to 62d5bd6 Compare November 28, 2023 21:02

ArchanaArige reviewed Dec 12, 2023

View reviewed changes

Adding Boottime Feature

950c362

Signed-off-by: Web-Dev-Manoj <[email protected]>

Web-Dev-Manoj force-pushed the BE-393-BootTimeFunctionality branch from 62d5bd6 to 950c362 Compare December 12, 2023 15:17

ArchanaArige approved these changes Dec 13, 2023

View reviewed changes

ArchanaArige merged commit 718e476 into hyperledger-labs:main Dec 13, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Boottime Feature #439

Adding Boottime Feature #439

Web-Dev-Manoj commented Sep 4, 2023 •

edited

Loading

SunnyAjin Sep 4, 2023

Web-Dev-Manoj Oct 3, 2023

SunnyAjin Sep 4, 2023

Web-Dev-Manoj Oct 3, 2023

SunnyAjin Sep 4, 2023

Web-Dev-Manoj Oct 3, 2023

ArchanaArige commented Sep 11, 2023 •

edited

Loading

Udhayakumari Sep 30, 2023

Web-Dev-Manoj Oct 3, 2023

Udhayakumari Sep 30, 2023

Web-Dev-Manoj Oct 3, 2023

Udhayakumari Sep 30, 2023

Web-Dev-Manoj Oct 3, 2023

Udhayakumari Sep 30, 2023

Web-Dev-Manoj Oct 3, 2023

ArchanaArige left a comment

Web-Dev-Manoj commented Oct 16, 2023

ArchanaArige left a comment

ArchanaArige left a comment

Adding Boottime Feature #439

Adding Boottime Feature #439

Conversation

Web-Dev-Manoj commented Sep 4, 2023 • edited Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation, usage docs, etc.:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArchanaArige commented Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArchanaArige left a comment

Choose a reason for hiding this comment

Web-Dev-Manoj commented Oct 16, 2023

ArchanaArige left a comment

Choose a reason for hiding this comment

ArchanaArige left a comment

Choose a reason for hiding this comment

Web-Dev-Manoj commented Sep 4, 2023 •

edited

Loading

ArchanaArige commented Sep 11, 2023 •

edited

Loading