-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress UI automated test cases of console #537
Conversation
Signed-off-by: Ketul Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really nice! i have a few thoughts:
- can we tie this to run automatically with github actions?
packages/cypress/cypress/fixtures/test_data/Import/IBP_Import.zip
Outdated
Show resolved
Hide resolved
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Added cypress.yml under workflows folder. |
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a few hundred more files now? looks like you copied the whole app under the cypress folder... if this is just for github actions, can you remove all of these, and when github actions is running add a copy bash command to get the source data from apollo/src
to where you want it.
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
Signed-off-by: Ketul Shah <[email protected]>
@dshuffma-ibm - As per discussion, this PR is updated with new folder structure and ReadMe file that says Protractor is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmm, i think i'll merge this regardless, but this file has a suspicious number of dependencies, we should only list the top level deps it takes to run this test. any dependencies of a dependency will automatically be tracked with the package-lock.json
file and thus they do not (and should not) be listed in our package.json
file.
sooo my ask is, can you strip down this list? starting on line 39?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally this will run automatically with our new builds, can you add a new github action test in the apollo file? https://github.com/hyperledger-labs/fabric-operations-console/blob/main/.github/workflows/apollo.yml#L12
Type of change
Cypress UI automated test cases of console
Description
Cypress UI automated test cases of console and readme file to start