Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress UI automated test cases of console #537

Merged
merged 27 commits into from
Oct 17, 2023
Merged

Cypress UI automated test cases of console #537

merged 27 commits into from
Oct 17, 2023

Conversation

ketulsha
Copy link
Contributor

@ketulsha ketulsha commented Oct 9, 2023

Type of change

Cypress UI automated test cases of console

Description

Cypress UI automated test cases of console and readme file to start

@ketulsha ketulsha requested a review from a team as a code owner October 9, 2023 13:25
Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really nice! i have a few thoughts:

packages/cypress/cypress/fixtures/config.json Outdated Show resolved Hide resolved
@ketulsha
Copy link
Contributor Author

this is really nice! i have a few thoughts:

Added cypress.yml under workflows folder.

Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a few hundred more files now? looks like you copied the whole app under the cypress folder... if this is just for github actions, can you remove all of these, and when github actions is running add a copy bash command to get the source data from apollo/src to where you want it.

@ketulsha
Copy link
Contributor Author

@dshuffma-ibm - As per discussion, this PR is updated with new folder structure and ReadMe file that says Protractor is deprecated.
Please review.Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm, i think i'll merge this regardless, but this file has a suspicious number of dependencies, we should only list the top level deps it takes to run this test. any dependencies of a dependency will automatically be tracked with the package-lock.json file and thus they do not (and should not) be listed in our package.json file.

sooo my ask is, can you strip down this list? starting on line 39?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this will run automatically with our new builds, can you add a new github action test in the apollo file? https://github.com/hyperledger-labs/fabric-operations-console/blob/main/.github/workflows/apollo.yml#L12

@dshuffma-ibm dshuffma-ibm merged commit b0941cd into hyperledger-labs:main Oct 17, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants