prevent the last manager from removing manager role #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prakash P S <[email protected]>
dshuffma-ibm
changed the title
added 2 commits
November 27, 2023 12:58
Signed-off-by: Prakash P S <[email protected]>
Signed-off-by: Prakash P S <[email protected]>
dshuffma-ibm
requested changes
Nov 30, 2023
| { | ||
| let admin_count = 0; | ||
| for (let user in settings_doc.access_list) { | ||
| if (user.roles.includes('manager')) |
There was a problem hiding this comment.
user isn't what you think it is, its just the key of the access_list object, so its just a string. to get to the properies of that user, it should be:
for (let id in settings_doc.access_list) {
let user = settings_doc.access_list[id];
if (user && user.roles && user.roles.includes('manager')) {
admin_count = admin_count + 1;
}
}There was a problem hiding this comment.
@dshuffma-ibm , I have updated the code as mentioned
Signed-off-by: Prakash P S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change