Build python wheel for eservice and pservice #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmickeyb
reviewed
May 4, 2023
marcelamelara
force-pushed
the
services-python-build
branch
from
25fbf7b
to
c0578dc
Compare
… in progress. Please see README_CCF_v4.md for usage instructions Signed-off-by: Ubuntu <ccf@prakash-services.ngrbedaihgkeramjr13nhjagoc.bx.internal.cloudapp.net>
…th what currently exists for v1.0.19 Signed-off-by: Ubuntu <ccf@prakash-services.ngrbedaihgkeramjr13nhjagoc.bx.internal.cloudapp.net>
In order to get the new CCF to run with the sandbox script several changes needed to be made. Most importantly, the ledger URL must be specified with an IP address, not a domain name. Second, the docker build process is slightly changed to accommodate the lack of a configuration step in the new build process. As part of that update, the dependency on PDO_LEDGER_URL environment variable for configuration is removed and the scripts for configuring the CCF instance now take explicit host/port parameters. As part of the update a lot of old unused code was removed from those scripts. Right now the code assumes that the creation of the ledger keys by the CCF node is a sufficient indicator that the node is ready. Some additional checks are in the generate_ledger_authority script which should be the first called after CCF is started. These checks should be added to the other scripts as well. Signed-off-by: Mic Bowman <[email protected]>
Added a new function for forcing name/address to an ip address. This is useful since CCF requires ledger URLs and interfaces to be specified as IP addresses. Pushed changes to use the new function into the docker tools and the script to start CCF. Signed-off-by: Mic Bowman <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
marcelamelara
force-pushed
the
services-python-build
branch
from
c0578dc
to
21dfd82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the deprecated python .egg package format for the eservice and pservice with the python .whl format. This is achieved by using more recent python build and install tooling.
Blocking #421. Addresses Task 1 of #437