Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build dependency bug fix #485

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Build dependency bug fix #485

merged 1 commit into from
Apr 17, 2024

Conversation

g2flyer
Copy link
Contributor

@g2flyer g2flyer commented Apr 17, 2024 •
edited
Loading

Discovered testing PDO contracts PR #32, see this comment

@g2flyer g2flyer mentioned this pull request Apr 17, 2024
Merged
cmickeyb
cmickeyb approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@cmickeyb cmickeyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine to me. waiting for @bvavala to test.

@g2flyer
Copy link
Contributor Author

g2flyer commented Apr 17, 2024

this looks fine to me. waiting for @bvavala to test.

looks fine but isn't ;-) just realized that it currently doesn't work for sgx_text ...

@g2flyer
Copy link
Contributor Author

g2flyer commented Apr 17, 2024 •
edited
Loading

this looks fine to me. waiting for @bvavala to test.

looks fine but isn't ;-) just realized that it currently doesn't work for sgx_text ...

Now it does ... (Note: fix is in fixup comment, so unless you want to do a squash-merge, @bvavala ping me before merging and i do the auto-squash)

@bvavala
Copy link
Member

bvavala commented Apr 17, 2024

this looks fine to me. waiting for @bvavala to test.

looks fine but isn't ;-) just realized that it currently doesn't work for sgx_text ...

Now it does ... (Note: fix is in fixup comment, so unless you want to do a squash-merge, @bvavala ping me before merging and i do the auto-squash)

Looks good, do you want to squash the commits?

Build dependency bug fix
2c93443 
Signed-off-by: Michael Steiner <[email protected]>
@g2flyer
Copy link
Contributor Author

g2flyer commented Apr 17, 2024

this looks fine to me. waiting for @bvavala to test.

looks fine but isn't ;-) just realized that it currently doesn't work for sgx_text ...

Now it does ... (Note: fix is in fixup comment, so unless you want to do a squash-merge, @bvavala ping me before merging and i do the auto-squash)

Looks good, do you want to squash the commits?

done

@bvavala bvavala merged commit 9144ca6 into hyperledger-labs:main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvavala bvavala bvavala approved these changes

@cmickeyb cmickeyb cmickeyb approved these changes

Assignees

@bvavala bvavala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g2flyer @bvavala @cmickeyb