Do not force logrus LogLevel on first log line #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
Chengxuan
reviewed
Nov 6, 2024
| @@ -33,6 +33,8 @@ var ( | |||
| initAtLeastOnce atomic.Bool | |||
jimthematrix
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedding Zeto, such as in Paladin, the fact that
logrus.SetLevelis called on first log line, is challenging as it resets the logging framework of the parent containing Go code.This PR instead suggests that callers need to cal
log.InitConfigdirectly if they wish to use Zeto as the primary logging configuration framework for their codebase.