Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a retry to the test-network ccaas chaincode init command #1088

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

arner
Copy link
Contributor

@arner arner commented Sep 18, 2023

Without this, the init command fails if the chaincode container is not ready.

@arner arner requested a review from a team as a code owner September 18, 2023 14:31
@denyeart
Copy link
Contributor

Thanks @arner , the change looks good, but you need to sign your commit for the DCO check to pass.

See:
https://github.com/hyperledger/fabric-samples/pull/1088/checks?check_run_id=16891205058

You can git commit --amend -s to sign and then re-push with -f to force push the updated commit.

Without this, the init command fails if the chaincode container is not ready.

Signed-off-by: Arne Rutjes <[email protected]>
@arner
Copy link
Contributor Author

arner commented Sep 22, 2023

Got it, done!

Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@denyeart denyeart merged commit 98f7481 into hyperledger:main Sep 27, 2023
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants