Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-network chaincode-as-a-service deployment #1132

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

bestbeforetoday
Copy link
Member

Resolves a regression introduced in e73bb71.

Previous change defaulted to "auto" as the sequence number but omitted the call to generate the correct sequence number for the "auto" value. This resulted in "auto" being used as the sequence number, which is an error since an integer is required.

Resolves a regression introduced in e73bb71.

Previous change defaulted to "auto" as the sequence number but omitted the call to generate the correct sequence number for the "auto" value. This resulted in "auto" being used as the sequence number, which is an error since an integer is required.

Signed-off-by: Mark S. Lewis <[email protected]>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review November 5, 2023 13:36
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner November 5, 2023 13:36
@bestbeforetoday
Copy link
Member Author

bestbeforetoday commented Nov 5, 2023

@denyeart @celder628 This should allow builds that make use of fabric-samples and the test-network to test chaincode-as-a-service to work again, which includes fabric-test and fabric-contract-api-go.

Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark!

@denyeart denyeart merged commit c0a0104 into hyperledger:main Nov 7, 2023
40 checks passed
@bestbeforetoday bestbeforetoday deleted the deploy-ccaas branch November 8, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants