add unit test against a real grpc server for common/deliverclient/blo… #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cksprovider/delivery_requester Signed-off-by: Amrit Prakash <[email protected]>
solo-daemon
force-pushed
the
deliveryRequesterUnitTest
branch
from
a4cb6af
to
0858f4e
Compare
Signed-off-by: Amrit Prakash <[email protected]>
solo-daemon
force-pushed
the
deliveryRequesterUnitTest
branch
from
0695783
to
50711a9
Compare
fix premature timeout of rpc connection during test fix premature timeout of rpc connection during test Signed-off-by: Amrit Prakash <[email protected]>
solo-daemon
force-pushed
the
deliveryRequesterUnitTest
branch
from
b6a43f7
to
7a07f65
Compare
tock-ibm
requested changes
May 7, 2024
|
|
||
| select { | ||
| case <-timer.C: | ||
| ds.t.Fatalf("timed out waiting for seek assertions to receive a value\n") |
There was a problem hiding this comment.
This can be t.Fatal() rather than t.Fatalf()
There was a problem hiding this comment.
Thanks for your contribution!
This PR is incomplete. Please move it to draft until you finish or tag it as WIP.
- Please don't remove the tests that use mocks, just add tests that communicate with a real grpc server
- Send a seek info message and check it is received
- Respond with a block and check it is received
- Check connecting with TLS and connection errors
|
Hello how to access free bitcoin |
|
Is it possible to access bitcoin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #4567
Update unit test for deliveryRequester.