Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add zkp issuance scenario #104

Merged
merged 8 commits into from
Dec 5, 2023
Merged

test: add zkp issuance scenario #104

merged 8 commits into from
Dec 5, 2023

Conversation

amagyar-iohk
Copy link
Contributor

Overview

Fixes #

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@atala-dev
Copy link
Contributor

atala-dev commented Nov 1, 2023 •
edited
Loading

Code Coverage

Total Project Coverage 26.22%

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Unit Test Results

66 tests  ±0   62 ✔️ ±0   2s ⏱️ ±0s
19 suites ±0     4 💤 ±0 
19 files   ±0     0 ❌ ±0 

Results for commit 4c75a82. ± Comparison against base commit b96501f.

♻️ This comment has been updated with latest results.

antonbaliasnikov
antonbaliasnikov approved these changes Nov 29, 2023
View reviewed changes
Copy link

@antonbaliasnikov antonbaliasnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/end-to-end/src/test/kotlin/io/iohk/atala/prism/configuration/Environment.kt Show resolved Hide resolved
tests/end-to-end/src/test/kotlin/io/iohk/atala/prism/utils/Keys.kt Outdated Show resolved Hide resolved
@amagyar-iohk amagyar-iohk merged commit 0b383f2 into main Dec 5, 2023
4 checks passed
@amagyar-iohk amagyar-iohk deleted the test/zkp-issuance branch December 5, 2023 11:39
hamada147 added a commit that referenced this pull request May 15, 2024
@amagyar-iohk @hamada147
test: add zkp issuance scenario (#104)
4f7c49b 
Co-authored-by: Ahmed Moussa <[email protected]>
Signed-off-by: Allain Magyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonbaliasnikov antonbaliasnikov antonbaliasnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amagyar-iohk @atala-dev @antonbaliasnikov