Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change usage from Mnemonic to MnemonicHelper from Apollo #117

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

hamada147
Copy link
Contributor

Overview

We don't need to use a normal class Mnemonic that internally just uses MnemonicHelper from Apollo and I want to remove it.

Fixes #

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@hamada147 hamada147 added the enhancement New feature or request label Dec 12, 2023
@hamada147 hamada147 self-assigned this Dec 12, 2023
@atala-dev
Copy link
Contributor

Code Coverage

File Coverage [57.14%]
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/apollo/ApolloImpl.kt 57.14%
Total Project Coverage 26.22%

Copy link

Unit Test Results

66 tests  ±0   62 ✔️ ±0   2s ⏱️ ±0s
19 suites ±0     4 💤 ±0 
19 files   ±0     0 ±0 

Results for commit 0621863. ± Comparison against base commit 0f487bd.

@hamada147 hamada147 merged commit 2b17b1b into main Dec 13, 2023
4 checks passed
@hamada147 hamada147 deleted the change-usage-from-Mnemonic-to-MnemonicHelper branch December 13, 2023 15:56
hamada147 added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants