Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: coveralls + megalinter #133

Merged
merged 10 commits into from
Mar 5, 2024
Merged

test: coveralls + megalinter #133

merged 10 commits into from
Mar 5, 2024

Conversation

amagyar-iohk
Copy link
Contributor

Overview

Fixes #

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Unit Test Results

68 tests  ±0   64 ✅ ±0   2s ⏱️ -3s
20 suites ±0    4 💤 ±0 
20 files   ±0    0 ❌ ±0 

Results for commit 76b3b42. ± Comparison against base commit 811402b.

♻️ This comment has been updated with latest results.

cristianIOHK
cristianIOHK requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a small change, the rest looks fine

hamada147
hamada147 suggested changes Mar 4, 2024
View reviewed changes
.mega-linter.yml Show resolved Hide resolved
atala-prism-sdk/build.gradle.kts Outdated Show resolved Hide resolved
atala-prism-sdk/build.gradle.kts Outdated Show resolved Hide resolved
@amagyar-iohk amagyar-iohk merged commit 044121a into main Mar 5, 2024
5 checks passed
@amagyar-iohk amagyar-iohk deleted the test/enhancements branch March 5, 2024 14:42
hamada147 added a commit that referenced this pull request May 15, 2024
@amagyar-iohk @hamada147
test: coveralls + megalinter (#133)
6319d53 
Co-authored-by: Ahmed Moussa <[email protected]>
Signed-off-by: Allain Magyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@hamada147 hamada147 hamada147 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amagyar-iohk @hamada147 @cristianIOHK