refactor: message attachment data #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results109 tests - 1 106 ✅ - 1 7s ⏱️ -1s Results for commit 7977f49. ± Comparison against base commit 06e9a8f. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
cristianIOHK
force-pushed
the
refactor/message_attachment_data
branch
from
46dafbf to
4e38c11
Compare
Signed-off-by: Cristian G <[email protected]>
cristianIOHK
force-pushed
the
refactor/message_attachment_data
branch
from
4e38c11 to
a889273
Compare
cristianIOHK
changed the title
cristianIOHK
changed the title
Pull Request Test Coverage Report for Build 10287895201Details
💛 - Coveralls |
Signed-off-by: Cristian G <[email protected]> fix: linting Signed-off-by: Cristian G <[email protected]>
cristianIOHK
force-pushed
the
refactor/message_attachment_data
branch
from
2f69565 to
7977f49
Compare
goncalo-frade-iohk
approved these changes
Aug 7, 2024
cristianIOHK
added a commit
that referenced
this pull request
Aug 27, 2024
Signed-off-by: Cristian G <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the message attachments adding a method to extract the data as a json string. That takes the responsibility of verifying the type of attachment data away from the users and provides a method to do it properly.
That method makes that functionality easier to maintain as all code uses the same logic, instead of having different implementations all over the code base.
Checklist: