Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the publishing process for hyperledger #184

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

cristianIOHK
Copy link
Contributor

Description:

This PR adds the proper config for the publishing process to hyperledger maven following the work @yshyn-iohk did on Apollo.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@coveralls
Copy link

coveralls commented Aug 8, 2024

Pull Request Test Coverage Report for Build 10307229905

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.977%

Totals Coverage Status
Change from base Build 10288062413: 0.0%
Covered Lines: 2996
Relevant Lines: 6098

💛 - Coveralls

Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

Copy link

github-actions bot commented Aug 8, 2024

Unit Test Results

109 tests  ±0   106 ✅ ±0   6s ⏱️ -1s
 24 suites ±0     3 💤 ±0 
 24 files   ±0     0 ❌ ±0 

Results for commit a39b3a4. ± Comparison against base commit b90cf9d.

♻️ This comment has been updated with latest results.

Signed-off-by: Cristian G <[email protected]>
@cristianIOHK cristianIOHK force-pushed the chore/publishing_to_maven_config branch from 7a9399c to b1064fb Compare August 9, 2024 16:49
@cristianIOHK cristianIOHK force-pushed the chore/publishing_to_maven_config branch from b1064fb to a39b3a4 Compare August 9, 2024 19:10
@cristianIOHK cristianIOHK merged commit 8bdb59b into main Aug 9, 2024
5 checks passed
@cristianIOHK cristianIOHK deleted the chore/publishing_to_maven_config branch August 9, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants