-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: goncalo-frade-iohk <[email protected]>
- Loading branch information
1 parent
2c2c4d1
commit 2e27c36
Showing
1 changed file
with
14 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,14 @@ | ||
| # Overview | ||
| <!-- What this PR does, and why is needed, a useful description is expected, and relevant tickets should be mentioned --> | ||
|
|
||
| Fixes #<issue number> | ||
|
|
||
| ## Checklist | ||
|
|
||
| ### My PR contains... | ||
| * [ ] No code changes (changes to documentation, CI, metadata, etc.) | ||
| * [ ] Bug fixes (non-breaking change which fixes an issue) | ||
| * [ ] Improvements (misc. changes to existing features) | ||
| * [ ] Features (non-breaking change which adds functionality) | ||
|
|
||
| ### My changes... | ||
| * [ ] are breaking changes | ||
| * [ ] are not breaking changes | ||
| * [ ] If yes to the above: I have updated the documentation accordingly | ||
|
|
||
| ### Documentation | ||
| * [ ] My changes do not require a change to the project documentation | ||
| * [ ] My changes require a change to the project documentation | ||
| * [ ] If yes to the above: I have updated the documentation accordingly | ||
|
|
||
| ### Tests | ||
| * [ ] My changes can not or do not need to be tested | ||
| * [ ] My changes can and should be tested by unit and/or integration tests | ||
| * [ ] If yes to the above: I have added tests to cover my changes | ||
| * [ ] If yes to the above: I have taken care to cover edge cases in my tests | ||
| ### Description: | ||
| Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable. | ||
| Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR. | ||
|
|
||
| ### Alternatives Considered (optional): | ||
| Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas. | ||
|
|
||
| ### Checklist: | ||
| - [] My PR follows the [contribution guidelines](https://github.com/input-output-hk/atala-prism-wallet-sdk-swift/blob/main/CONTRIBUTING.md) of this project | ||
| - [] My PR is free of third-party dependencies that don't comply with the [Allowlist](https://toc.hyperledger.org/governing-documents/allowed-third-party-license-policy.html#approved-licenses-for-allowlist) | ||
| - [] I have commented my code, particularly in hard-to-understand areas | ||
| - [] I have made corresponding changes to the documentation | ||
| - [] I have added tests that prove my fix is effective or that my feature works | ||
| - [] I have checked the PR title to follow the [conventional commit specification](https://www.conventionalcommits.org/en/v1.0.0/) |