Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experience): fix didcommagent state enum typo #184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

coveloper
Copy link

@coveloper coveloper commented Jan 6, 2025

Description:

Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable.
Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.

Fix typo in DIDCommAgent State enum value. Should not break SDK however potential for downstream breaking change if users have relied on the misspelling in their consumer code.

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@coveloper coveloper requested a review from a team as a code owner January 6, 2025 08:09
@coveloper coveloper force-pushed the jon/fix-stoped-typo branch from 31a9d5e to a1c7d58 Compare January 6, 2025 08:11
@coveloper coveloper force-pushed the jon/fix-stoped-typo branch from 6b9dae3 to 021df00 Compare January 6, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants