Suppress implicit return in _is_data_scaleint, also codestyle

hyperspy · Jun 25, 2024 · 94f0ae1 · 94f0ae1
1 parent d914fda
commit 94f0ae1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/rsciio/digitalsurf/_api.py b/rsciio/digitalsurf/_api.py
@@ -2200,6 +2200,8 @@ def _is_data_scaleint(
             "_INTENSITYIMAGE",
         ]:
             return True
+        else:
+            return False
 
     def _get_uncompressed_datasize(self) -> int:
         """Return size of uncompressed data in bytes"""

diff --git a/rsciio/tests/test_digitalsurf.py b/rsciio/tests/test_digitalsurf.py
@@ -664,6 +664,8 @@ def test_norm_int_data(dtype, special, fullscale):
         dat[2] = minint
         dat[11] = maxint
 
+    Zscale = 0.0 #to avoid CodeQL error: pot. non-initialized var
+    Zoffset = -np.inf #to avoid CodeQL error: pot. non-initialized var
     pointsize, Zmin, Zmax, Zscale, Zoffset, data_int = dh._norm_data(dat, special)
 
     off = minint + 1 if special and fullscale else dat.min()
@@ -690,7 +692,7 @@ def test_writetestobjects_rgb(tmp_path,transpose):
             d.save(fn)
     else:
         d.save(fn)
-        
+
     d2 = hs.load(fn)
     d2.save(fn)
     d3 = hs.load(fn)