fix vulnerabilities in docker image #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ravisingal
commented
Oct 20, 2022
ravisingal
commented
- fix vulnerabilities in docker image
- add capability to mount existing claim in pinot controller pods
- update prometheus-jmx-exporter image version
2. add capability to mount existing claim in pinot controller pods
ravisingal
requested review from
aaron-steinfeld,
tim-mwangi and
laxmanchekka
as code owners
ravisingal
commented
Oct 20, 2022
|
|
||
| # Fetch jar | ||
| RUN curl -L -o $PINOT_HOME/lib/pinot-all-${JITPACK_TAG}-shaded.jar \ | ||
| https://jitpack.io/com/github/${JITPACK_REPO}/pinot-distribution/${JITPACK_TAG}/pinot-distribution-${JITPACK_TAG}-shaded.jar | ||
|
|
||
| # Fetch plugin jars | ||
| RUN for artifactId in pinot-kafka-2.0 pinot-kinesis pinot-thrift pinot-json pinot-parquet pinot-orc pinot-csv pinot-confluent-avro pinot-avro pinot-protobuf pinot-batch-ingestion-standalone pinot-batch-ingestion-hadoop pinot-batch-ingestion-spark pinot-hdfs pinot-adls pinot-gcs pinot-s3 pinot-minion-builtin-tasks pinot-segment-uploader-default pinot-segment-writer-file-based pinot-dropwizard pinot-yammer; do \ |
There was a problem hiding this comment.
Removed the following 3 plugins having critical vulnerabilities:
- pinot-input-format/pinot-orc
- pinot-input-format/pinot-parquet
- pinot-batch-ingestion/pinot-batch-ingestion-spark
There was a problem hiding this comment.
Assuming we are not using them?
ravisingal
commented
Oct 20, 2022
| curl -L -o $PINOT_HOME/plugins/${artifactId}-${JITPACK_TAG}-shaded.jar \ | ||
| https://jitpack.io/com/github/${JITPACK_REPO}/${artifactId}/${JITPACK_TAG}/${artifactId}-${JITPACK_TAG}-shaded.jar; \ | ||
| done | ||
|
|
||
| FROM openjdk:11-jre-slim |
There was a problem hiding this comment.
openjdk images are deprecated. docker-library/openjdk#505
ravisingal
commented
Oct 20, 2022
| @@ -133,9 +133,15 @@ spec: | |||
| - name: log-config | |||
| configMap: | |||
| name: {{ include "pinot.controller.fullname" . }}-log-config | |||
| {{- if not .Values.controller.persistence.enabled }} | |||
| {{- if .Values.controller.persistence.existingClaim }} | |||
There was a problem hiding this comment.
if existingClaim is defined, it will be used instead of creating a new PVC.
tim-mwangi
previously approved these changes
Oct 20, 2022
ravisingal
commented
Oct 20, 2022
| @@ -457,7 +458,7 @@ server: | |||
| port: 7071 | |||
| image: | |||
| repository: hypertrace/prometheus-jmx-exporter | |||
| tag: 0.1.0 | |||
| tag: 0.1.1 | |||
There was a problem hiding this comment.
laxmanchekka
previously approved these changes
Oct 20, 2022
ravisingal
dismissed stale reviews from laxmanchekka and tim-mwangi
via
1a1f7af
ravisingal
commented
Oct 20, 2022
| @@ -45,13 +45,19 @@ spec: | |||
| exitCode=1 | |||
| i=0 | |||
| while [ $i -le {{ .Values.zookeeper.retries }} ]; do | |||
| bin/zookeeper-shell.sh ZooKeeper -server {{ include "zookeeper.url" . | quote }} create {{ .Values.zookeeper.path | quote }} "" | |||
| bin/zookeeper-shell.sh ZooKeeper -server {{ include "zookeeper.url" . | quote }} ls {{ .Values.zookeeper.path | quote }} | |||
There was a problem hiding this comment.
new image returns error if the node already exist in zookeeper.
WatchedEvent state:SyncConnected type:None path:null
Node already exists: /pinot
[2022-10-20 16:45:45,596] ERROR Exiting JVM with code 1 (org.apache.zookeeper.util.ServiceUtils)
updated script to first check the node before creating it.
tim-mwangi
approved these changes
Oct 20, 2022
laxmanchekka
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.