Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/invite service #210

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Feature/invite service #210

merged 9 commits into from
Jul 20, 2023

Conversation

n13
Copy link
Collaborator

@n13 n13 commented Jul 19, 2023

  • Added invite service
  • Changed config to have different ppp services for all networks
  • Parsing ppp service config from config file

Redeem invite needs to be called with a String which maps to a checksum256 (basically a hex string of a certain length)

We receive this secret as an additional parameter in invite

We will need to process invites / account create links, then process invite code, and call the invite service to enroll into a DAO

this is the first step in the wallet do do this.

@n13 n13 mentioned this pull request Jul 19, 2023
add network to member service
@n13 n13 mentioned this pull request Jul 19, 2023
Copy link
Contributor

@gguijarro-c-chwy gguijarro-c-chwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. pls fix typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assets/config/profile_serivce/config.json
assets/config/profile_service/config.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this file coming from? Is this a AWS config?

@gguijarro-c-chwy
Copy link
Contributor

Linter is failing too

@n13
Copy link
Collaborator Author

n13 commented Jul 19, 2023

Fixed typo

IDK what linter is complaining about seems to be something internal to GH actions

@n13 n13 merged commit e59a942 into main Jul 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants