[DRAFT] Full network support #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
commented
Jul 20, 2023
| remoteConfigService.clientId, | ||
| CognitoUserPool userPool(Network network) => CognitoUserPool( | ||
| remoteConfigService.userPoolId(network), | ||
| remoteConfigService.clientId(network), | ||
| ); | ||
| CognitoUser? cognitoUser; | ||
| CognitoUserSession? session; | ||
|
|
||
| RemoteConfigService get remoteConfigService => eosService.remoteConfigService; |
There was a problem hiding this comment.
I guess this should be a single network specific object with all the ppp parameters in it.
n13
commented
Jul 20, 2023
| @@ -104,23 +104,23 @@ class RemoteConfigService { | |||
| String get accountCreatorEndpoint => FirebaseRemoteConfig.instance.getString('accountCreatorEndpoint'); | |||
|
|
|||
| // PPP Service AWS | |||
There was a problem hiding this comment.
I guess the below methods should be a single network specific object with all the ppp parameters in it.
n13
changed the title
n13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your review
Seems like we could do something more elegant than using "network" everywhere
For example we could pass it around instead of accountName
The problem is now that network is stored in user profile, and I am not sure we always have one
If we always have one then we could always pass around a user profile, or an object with only accountName and network everywhere, and not have this parameter pollute the whole code base.
IDK