Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/loading animation layout fix #238

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

n13
Copy link
Collaborator

@n13 n13 commented Aug 21, 2023

Launch animation updates

  • Launch screen background in iOS matches animation (instead of white and empty). Note: This is the native, static, iOS launch screen - it doesn't do animations, and it's outside of flutter code base.
  • Animation uses cover fit so it is always centered, always covers the entire screen, and does not get stretched

Still do do @gguijarro-c-chwy :

  • Because the home screen also has a "SplashPage" which appears for a brief moment, the initial animation looks like it's off center and then moving into center. We are starting the animation twice. Not sure what the best solution is there - but also not sure why we have 3 places where splashpage is invoked - seems there should just be one?!
  • Android - does it also have a native/static launch screen that should match the color?

I didn't put a hypha logo on the launch screen because centering might then be an issue and it would maybe interfere with the animation.

In order to get lotte animation to cover properly it needs to be inside a FittedBox, as per documentation.
@n13 n13 merged commit 94c00ab into main Aug 22, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants