Use new Icons lib #257
Merged
Use new Icons lib #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
reviewed
Sep 15, 2023
| android: | ||
| enable: true | ||
| ios: | ||
| enable: true | ||
|
|
There was a problem hiding this comment.
you need to set adaptive_icon_background or background color and foreground to make the round icons work
Which is sort of the point here.
There was a problem hiding this comment.
nm I ended up doing it in android studio, because it has a preview so I can see everything it's doing.
because I am definitely going to forget how this works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results are not ideal on android.
I ended up creating all icons in Android studio - it has a very good UX for this, and shows all outcomes. So this is way better than what I did before.
Turned off android in the package