Wallet team feedback #264
Merged
Wallet team feedback #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gguijarro-c-chwy
commented
Oct 5, 2023
gguijarro-c-chwy
commented
added 3 commits
October 5, 2023 10:12
n13
reviewed
Oct 6, 2023
| children: [ | ||
| Padding( | ||
| padding: const EdgeInsets.only(bottom: 8), | ||
| child: Text(error.message, style: context.hyphaTextTheme.ralMediumBody), |
There was a problem hiding this comment.
not sure error.message is what we need? Does that contain the blockchain error message? Did we test this?
n13
reviewed
Oct 6, 2023
|
Sample QR for testing what will fail 
|
…let into wallet_team_feedback
|
Shows blockchain error message as expected
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.