Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement logic to retrieve active proposals #284

Merged
merged 3 commits into from
Aug 23, 2024
Merged

feat: implement logic to retrieve active proposals #284

merged 3 commits into from
Aug 23, 2024

Conversation

Zied-Dahmani
Copy link
Collaborator

@Zied-Dahmani Zied-Dahmani commented Aug 22, 2024 •
edited
Loading

Scope

Ticket

Implemented logic to retrieve active proposals for the proposals page.
Note: Still investigating the specifics of b6 30% and Marketing Circle.

@Zied-Dahmani Zied-Dahmani requested a review from n13 August 22, 2024 20:30
@Zied-Dahmani Zied-Dahmani self-assigned this Aug 22, 2024
@Zied-Dahmani Zied-Dahmani linked an issue Aug 22, 2024 that may be closed by this pull request
Retrieve Active Proposals #283
Closed
n13
n13 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@n13 n13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks clean

I guess this does not implement the user interface for showing the proposals?

Missing a "refresh" command to reload the proposals - the page needs to have a pull to reload function.

@Zied-Dahmani
Copy link
Collaborator Author

Code looks clean

I guess this does not implement the user interface for showing the proposals?

Missing a "refresh" command to reload the proposals - the page needs to have a pull to reload function.

Thank you.
Saif is currently working on the UI and will include the pull-to-refresh.
I have just added a parameter to the event to support this.

@Zied-Dahmani Zied-Dahmani merged commit 4ff6e68 into main Aug 23, 2024
0 of 3 checks passed
@Zied-Dahmani Zied-Dahmani deleted the feat/implement-retrieve-active-proposals-logic branch August 23, 2024 11:04
@Zied-Dahmani Zied-Dahmani restored the feat/implement-retrieve-active-proposals-logic branch August 23, 2024 11:04
@Zied-Dahmani Zied-Dahmani added feature Super Awesome Future Features and removed feature Super Awesome Future Features labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n13 n13 n13 approved these changes

Assignees

@Zied-Dahmani Zied-Dahmani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve Active Proposals
2 participants
@Zied-Dahmani @n13