Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Handle creator and DAO images display in proposal details #338

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

nbetsaif
Copy link
Collaborator

@nbetsaif nbetsaif commented Oct 1, 2024

This PR implements the handling of both creator and DAO images in the proposal details view. The changes ensure that images are correctly fetched and displayed for both the proposal creator and associated DAO.

Screenshots

Before After
Before After

@nbetsaif nbetsaif requested a review from n13 October 1, 2024 15:33
@nbetsaif nbetsaif self-assigned this Oct 1, 2024
@nbetsaif nbetsaif linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbetsaif nbetsaif merged commit 3689955 into main Oct 3, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAO == Null (Proposal Details)
2 participants