feat: implement proposal review page #346
Conversation
| final String? _text; | ||
|
|
||
| // TODO(Zied-Saif): figure this out | ||
| const ProposalHeader(this._dao, {String text = 'Marketing Circle', super.key}) : _text = text; | ||
|
|
There was a problem hiding this comment.
Hmm why is Marketing Circle hard-coded here?
There was a problem hiding this comment.
If this is supposed to be the circle it could either be an empty string (no circle) - which should then be the default, or some other text if there is a circle selected.
There was a problem hiding this comment.
I have no idea what the Marketing Circle is, so we let it default, created a ticket, and will get back to it later (I remember Luigi said we would remove it).
There was a problem hiding this comment.
Ok please make the default "" empty string then.
There was a problem hiding this comment.
I don't think it's OK to merge something that is clearly wrong. Principle. Just like we don't merge bugs.
There was a problem hiding this comment.
Empty string should be fine as default - some proposals will have a circle some won't (default is no circle)
Scope
Ticket
I have implemented the
proposal creation (review and publish)page UI.Screenshots