fix cursor gsettings on session change #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
instead of moving it all to CCursorManager when its a kinda xcursor only feature, why not just make the syncGsettings public in XCursoManager, and the function in CCursorManager does m_pXCursor->syncGsettings(..) |
|
yeah didn't look into it too far and thought it wasnt related to xcursor edit: |
ikalco
force-pushed
the
fix_cursor_gsettings
branch
from
6c30922
to
5a6ea2d
Compare
|
wait is this ready |
|
yea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
when changing session gsettings cursor-theme can be changed
this resets it to what we want when switching back
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
yes