Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix on screen kb stuck super key #7306

Closed
wants to merge 1 commit into from

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Aug 12, 2024

Describe your PR, what does it fix/add?

fixes #7135

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

@cjuniorfox can you double check this works

also should this be an option or not vaxry?

Is it ready for merging, or does it need work?

yes

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fix sucks. Can we instead refactor keybind dispatchers to return a status code where one is like passthrough or something meaning the bind did execute but shouldnt be taken as consuming? (e.g. in the case of a mouse bind on a non-window)

@vaxerski
Copy link
Member

would also open up a path for hyprctl to return fail on a dispatcher that explicitly fails

@ikalco
Copy link
Contributor Author

ikalco commented Aug 14, 2024

will close cus #7331

@ikalco ikalco closed this Aug 14, 2024
@ikalco ikalco deleted the fix_onscreenkb_super branch August 14, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wvkbd
2 participants