hyprctl: avoid parsing string::npos on invalid cmd #7544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invalid lines passed to hyprctl keyword made the string parsing try to parse std::string::npos, avoid that and return an error text instead.
|
are there keywords that can be called without a value provided etc? as im checking now it returns a fail message if no value is parsed. |
vaxerski
previously approved these changes
Aug 27, 2024
doesn't make sense, no |
vaxerski
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalid lines passed to hyprctl keyword made the string parsing try to parse std::string::npos, avoid that and return an error text instead.
caused it to return garbled output etc when giving it invalid lines.
Fixes: #7424