-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix swallowing for groups #8223
Conversation
I'm gonna refactor this PR. |
In the end, this is the best approach that I could achieve. |
I'll read this tomorrow. Generally, windows should be separated from containers internally in the codebase, heh, but it's way too late for that. |
yeah, I tried but I wasn't able to separate them. |
yeah at this point it'd be really hard + break a lot of plugins, plus prolly introduce tons of bugs. Shit's... good enough I guess. I don't think we'll be doing anything fancier than groups on windows. |
This reverts commit a3d3b4f.
Describe your PR, what does it fix/add?
Fixes #8206
Is it ready for merging, or does it need work?
Ready.