fix swallowing for groups #8223
Merged
+32
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm gonna refactor this PR. |
|
In the end, this is the best approach that I could achieve. |
|
I'll read this tomorrow. Generally, windows should be separated from containers internally in the codebase, heh, but it's way too late for that. |
|
yeah, I tried but I wasn't able to separate them. |
|
yeah at this point it'd be really hard + break a lot of plugins, plus prolly introduce tons of bugs. Shit's... good enough I guess. I don't think we'll be doing anything fancier than groups on windows. |
vaxerski
reviewed
Oct 26, 2024
vaxerski
approved these changes
Oct 27, 2024
Aqa-Ib
added a commit
to Aqa-Ib/Hyprland
that referenced
this pull request
Oct 27, 2024
This reverts commit a3d3b4f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes #8206
Is it ready for merging, or does it need work?
Ready.