Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with hyprland-session.service #8251

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Build with hyprland-session.service #8251

merged 6 commits into from
Oct 26, 2024

Conversation

izmyname
Copy link
Contributor

Describe your PR, what does it fix/add?

Hyprland is now built with hyprland-session.service

Is there anything you want to mention?

Using both meson and cmake vars in hyprland-session.service looks hacky, but it's the best solution I could come up with, given my experience.

Is it ready for merging, or does it need work?

Ready

systemd/hyprland-session.service.in Outdated Show resolved Hide resolved
systemd/hyprland-session.service.in Outdated Show resolved Hide resolved
systemd/meson.build Outdated Show resolved Hide resolved
@izmyname izmyname requested a review from fufexan October 26, 2024 18:40
CMakeLists.txt Outdated Show resolved Hide resolved
systemd/hyprland-session.service.in Outdated Show resolved Hide resolved
systemd/meson.build Outdated Show resolved Hide resolved
systemd/meson.build Outdated Show resolved Hide resolved
@izmyname izmyname requested a review from fufexan October 26, 2024 19:22
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fufexan fufexan merged commit f3f7d36 into hyprwm:main Oct 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants