Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build failed in big-endian system #117

Merged
merged 1 commit into from
Dec 25, 2023
Merged

fix: build failed in big-endian system #117

merged 1 commit into from
Dec 25, 2023

Conversation

tobiichi3227
Copy link
Contributor

Close #40

vaxerski
vaxerski reviewed Dec 23, 2023
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye but what about png

@tobiichi3227
Copy link
Contributor Author

I checked cairo library source code.
They have do this part.

@vaxerski
Copy link
Member

have you checked this on a big endian?

@tobiichi3227
Copy link
Contributor Author

Yes.
I checked on qemu-powerpc64 platform by writing a simple cairo program.

vaxerski
vaxerski approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright then, I can't test, but who even uses big endian, tbh :P

@vaxerski vaxerski merged commit ef0e051 into hyprwm:main Dec 25, 2023
1 check passed
@vaxerski
Copy link
Member

thanks!

@tobiichi3227
Copy link
Contributor Author

Indeed.
I even cannot run hyprland on qemu-powerpc64.

vaxerski pushed a commit that referenced this pull request Jul 17, 2024
@tobiichi3227 @vaxerski
core: fix build failed in big-endian system (#117)
72c4279 
Close #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tobiichi3227 @vaxerski