Disable splash message by default #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jan 4, 2024
vaxerski
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Change default value of splash to false * put splash and ipc options into example config in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address hyprwm/hyprland#4338 by making the splash text an opt-in system.
As a first time user of hyprpaper, having the flavor text enabled by default is not something that is initially expected. While the splash text gives some character, having it on OOTB gives a double-take to the user, who most likely will turn it off.
If the outright default disable is overkill, it would be nice to make the option easier to find (hence the README change) instead of it being buried at the bottom of the page.