Add support for JPEG-XL #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrufat
force-pushed
the
add-jxl-support
branch
3 times, most recently
from
cef1268 to
32f5162
Compare
arrufat
commented
Nov 17, 2024
arrufat
force-pushed
the
add-jxl-support
branch
from
32f5162 to
4e8d601
Compare
vaxerski
approved these changes
Nov 20, 2024
|
@fufexan ci pls |
fufexan
force-pushed
the
add-jxl-support
branch
from
4e8d601 to
bdb7b3b
Compare
|
@vaxerski ready to go. |
vaxerski
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85.
It works except for a problem where colors are loaded backwards.
I thought it was a problem of endianness, so I played with
https://libjxl.readthedocs.io/en/latest/api_common.html#_CPPv413JxlEndianness
However, even setting any of the three values (big, little, native) leads to the same results.
I will continue to check later. But in case someone wants to give it a try, here it is.
EDIT: working now by forcing LITTLE_ENDIAN and manually arranging the pixels.