implement wl_output_transform #224
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Dec 17, 2024
|
@vaxerski should be fixd |
vaxerski
reviewed
Dec 19, 2024
|
@vaxerski this should be fine now |
|
In essence, when a geometry event is recieved, it compares the new transforms' and old transforms' parity with a bitwise XOR operation (yay a whole extra 1 picosecond of performance), meaning if and only if ONE of the transforms has a parity of 1 (because only odd transforms 1,3,5,7 describe rotations of 90 or 270 degrees) then a size swap needs to occur (i feel so smart !). From what I can tell, this SHOULD handle all cases and combinations of mode and transform events. |
|
you can appreciate the elegance tho right? im proud at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very simple change; ready to be merged whenever.
2024-12-17.00-57-07.mp4