core: fix reported display resolutions when fractionally scaled #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outfoxxed
force-pushed
the
fix-resolution-scaling
branch
from
bbbdd0c to
4177fc3
Compare
Qt appears to have no way to retrieve the pixel size sent by wayland, as it overrides it with the logical size and will not return the physical one.
outfoxxed
force-pushed
the
fix-resolution-scaling
branch
2 times, most recently
from
6807477 to
6b06084
Compare
vaxerski
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect reported display sizes when fractional scaling is enabled.
Yes, enumerating outputs is actually required for this. Qt only exposes logical size, and while QWaylandScreen has a field for this, its private and I would rather us not get hit with ABI breaks.