Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add STATIC_LIB option #343

Merged
merged 2 commits into from
Oct 24, 2024
Merged

add STATIC_LIB option #343

merged 2 commits into from
Oct 24, 2024

Conversation

valentinstoecker
Copy link
Collaborator

The STATIC_LIB optin compiles rayx-core as a static library.
This option is need to compile the python plugin

Copy link
Collaborator

@Atraxus Atraxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We define options for compiling the code in the root CMakeLists.txt file (e.g. WERROR, RAYX_ENABLE_CUDA). RAYX_STATIC_LIB should be an option there too. You can then simply use -DRAYX_STATIC_LIB=YES to set it during CMake configuration. In CMake you can then use

if(RAYX_STATIC_LIB) 
    ....
else()
    ....
endif()

@ichinii ichinii self-requested a review October 22, 2024 13:09
@valentinstoecker valentinstoecker requested review from Atraxus and removed request for Atraxus October 23, 2024 08:42
use cmake option

remove NFD extended
@valentinstoecker valentinstoecker force-pushed the add-static-library-option branch from 5a3ffb8 to d18ffc9 Compare October 24, 2024 09:47
@valentinstoecker valentinstoecker force-pushed the add-static-library-option branch from e6606be to 926425f Compare October 24, 2024 09:51
@valentinstoecker valentinstoecker merged commit eccdd10 into master Oct 24, 2024
6 checks passed
@valentinstoecker valentinstoecker deleted the add-static-library-option branch October 24, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants