-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only overwrite ns
config if it provided
#2270
Conversation
I don't really understand what this should exactly change... |
ns
config if it provided
@adrai I just update my PR, can you take a look, I split this to every step for each commit, and add example |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
f40fc70
to
2f9a93d
Compare
@adrai Currently, I'm not having any a solution for handling this mismatch. Since rendering occurs on the server side, while the client side lacks namespace information for preloading, translations won't occur, leading to a mismatch. For test fail, because I'm missing add build:example for that |
The mismatch is exactly because setversideTranslations is not called... so this will never work. The mismatch needs to be resolved else I can't merge this PR. |
I update to use config |
it's included in v15.3.0 |
Now we require including
serverSideTranslation
to every page that needed to translateWith this change, we can ignore that behavior by using all namespace available
Checklist
npm run test
Checklist (for documentation change)