Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Django5+ #610

Closed
wants to merge 1 commit into from
Closed

Support Django5+ #610

wants to merge 1 commit into from

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Apr 4, 2024 •
edited
Loading

Closes #606

q0w
q0w commented Apr 4, 2024
View reviewed changes
dj_rest_auth/tests/requirements.pip
django>=2.2,<5.0
djangorestframework-simplejwt==4.6.0
django>=2.2
djangorestframework-simplejwt>=5.3.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jazzband/djangorestframework-simplejwt#756
without this

ImportError: Could not import 'dj_rest_auth.jwt_auth.JWTCookieAuthentication' for API setting 'DEFAULT_AUTHENTICATION_CLASSES'. ImportError: cannot import name 'utc' from 'django.utils.timezone'

q0w
q0w commented Apr 4, 2024
View reviewed changes
dj_rest_auth/tests/test_serializers.py
@@ -2,7 +2,7 @@
from allauth.socialaccount.providers.facebook.views import FacebookOAuth2Adapter
from allauth.socialaccount.providers.facebook.views import FacebookProvider
from allauth.socialaccount.models import SocialApp
from allauth.exceptions import ImmediateHttpResponse
from allauth.core.exceptions import ImmediateHttpResponse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

allauth.exceptions is deprecated, use allauth.core.exceptions

@q0w
Copy link
Contributor Author

q0w commented Apr 4, 2024 •
edited
Loading

Current CI uses only python3.8 for testing and building. Maybe migrate to GHA all the way?

@awwester
Copy link

awwester commented Apr 6, 2024

@q0w is it necessary to update simplejwt when allowing Django 5? #607 just updates the django requirement and passes CI tests.

@q0w
Copy link
Contributor Author

q0w commented Apr 6, 2024 •
edited
Loading

@awwester yes, it seems necessary, tests are failing without it

#610 (comment)

#607 does not add django5 to testing, so ci checks only Django4

@vasilistotskas
Copy link

Any updates on this ?

@iMerica
Copy link
Owner

iMerica commented Apr 13, 2024

Waiting on @q0w to address all feedback.

@q0w
Copy link
Contributor Author

q0w commented Apr 13, 2024 •
edited
Loading

I already did
The current CI setup does not allow installing Django 5.
I think circleci should be rewritten to support all python versions or dropped in favour of GHA

@iMerica
Copy link
Owner

iMerica commented Apr 13, 2024

Good call, I'm going to switch this repo to use GHA.

@iMerica iMerica mentioned this pull request Apr 15, 2024
Merged
@iMerica
Copy link
Owner

iMerica commented Apr 15, 2024

Closing in favor of #615

(I've included the commits from this PR)

@iMerica iMerica closed this Apr 15, 2024
@q0w q0w deleted the django5 branch April 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support django 5+
4 participants
@q0w @awwester @vasilistotskas @iMerica